TST: clean-up various tests avoiding CoW issues #55861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
added
the
Testing
Comment on lines
-750
to
+754
| df.loc[1:2] = 0 | ||
| expected = df.iloc[0:2] | ||
| msg = r"The behavior of obj\[i:j\] with a float-dtype index" | ||
| with tm.assert_produces_warning(FutureWarning, match=msg): | ||
| result = df[1:2] | ||
| assert (result == 0).all().all() | ||
| tm.assert_frame_equal(result, expected) |
There was a problem hiding this comment.
No idea why we are setting values to 0 to then check that the indexing result also has values of 0. Can also use a plain assert_frame_equal, which seems simpler.
Comment on lines
-220
to
+221
| series = cp["A"] | ||
| series[:] = 10 | ||
| for idx, value in series.items(): | ||
| assert float_frame["A"][idx] != value | ||
| cp.loc[0, "A"] = 10 | ||
| assert not float_frame.equals(cp) |
There was a problem hiding this comment.
This seems a tedious way to check that cp is an actual copy (getting a column, mutating that column, and then iterating through column values), while we can also use a simpler direct mutation and single assert
| @@ -322,15 +322,15 @@ def test_set_value_by_index(self): | |||
|
|
|||
| df = DataFrame(np.arange(9).reshape(3, 3).T) | |||
| df.columns = list("AAA") | |||
| expected = df.iloc[:, 2] | |||
| expected = df.iloc[:, 2].copy() | |||
There was a problem hiding this comment.
Copying those "expected" frames avoids any potential issues where expected might be modified(or not) through what is actually being tested
mroeschke
approved these changes
Nov 7, 2023
|
Nice thanks @jorisvandenbossche |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few smaller and independent test changes broken off from #55838