Skip to content

CLN/BUG: Fix stacklevel on setting with copy warning. #5581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2013
+6 −3
Merged

CLN/BUG: Fix stacklevel on setting with copy warning. #5581

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions pandas/core/generic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1015,8 +1015,11 @@ def _setitem_copy(self, copy):
self._is_copy = copy
return self

def _check_setitem_copy(self):
""" validate if we are doing a settitem on a chained copy """
def _check_setitem_copy(self, stacklevel=4):
""" validate if we are doing a settitem on a chained copy.

If you call this function, be sure to set the stacklevel such that the
user will see the error *at the level of setting*"""
if self._is_copy:
value = config.get_option('mode.chained_assignment')

Expand All @@ -1026,7 +1029,7 @@ def _check_setitem_copy(self):
if value == 'raise':
raise SettingWithCopyError(t)
elif value == 'warn':
warnings.warn(t, SettingWithCopyWarning)
warnings.warn(t, SettingWithCopyWarning, stacklevel=stacklevel)

def __delitem__(self, key):
"""
Expand Down