Skip to content

Update _core.py to show valid plot types in the Error Message for Invalid plot kind #55758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Update _core.py to show valid plot types in the Error Message for Invalid plot kind #55758

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5692a40
Update _core.py to show valid plot types in the Error Message for Inv…
ahmadmustafaanis Oct 30, 2023
5b22811
Update _core.py with multiline exception message
ahmadmustafaanis Oct 30, 2023
9f1683a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pandas/plotting/_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -961,7 +961,7 @@ def __call__(self, *args, **kwargs):
return plot_backend.plot(self._parent, x=x, y=y, kind=kind, **kwargs)

if kind not in self._all_kinds:
raise ValueError(f"{kind} is not a valid plot kind")
raise ValueError(f"{kind} is not a valid plot kind\nValid plot kinds {self._all_kinds}")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just add a new line in the file instead of \n?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

raise ValueError(f"""{kind} is not a valid plot kind
Valid plot kinds {self._all_kinds}""")

Like this? Otherwise it will raise value error and will not go on next line. Maybe I can completely remove \n

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can check out examples in the repo where there are multi-line exception messages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


# The original data structured can be transformed before passed to the
# backend. For example, for DataFrame is common to set the index as the
Expand Down