Backport PR #55619 on branch 2.1.x (BUG: Groupby not keeping string dtype for empty objects) #55705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…5619) * BUG: Groupby not keeping string dtype for empty objects * Fix --------- Co-authored-by: Thomas Li <[email protected]> (cherry picked from commit 8afd868)
|
Just needed to move a test for this one. |
|
Ack, looks like there's a segmentation fault here. @phofl I'm gonna bump this off the milestone then. |
|
Yeah no worries |
|
Nevermind about the segfault, it seems to be unrelated to this PR (I saw it happen on the 2.1.x branch too, and I made a comment about it on the release issue). I'll send a PR to move the release note. |
|
Oops, looks like I accidentally hit close on this for some reason. (I think I meant to hit merge). |
|
Merging, I need to move the release note now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG: Groupby not keeping string dtype for empty objects
Fix
Backports PR #55619