TST: Remove unnecessary read_csv usage during testing #55643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
the
Testing
WillAyd
reviewed
Oct 23, 2023
pandas/tests/groupby/test_apply.py
Outdated
| 1.40649, | ||
| ], | ||
| }, | ||
| index=Index(pd.to_datetime(ts.split("\n")), name="date_time"), |
There was a problem hiding this comment.
Is this any different from just making ts a list to begin with?
There was a problem hiding this comment.
Good point. Made this into a list
| def asof(self, datapath): | ||
| return self.read_data(datapath, "asof.csv") | ||
| def asof(self): | ||
| df = pd.DataFrame( |
There was a problem hiding this comment.
I think since this is reused a few times in the module we should make it a fixture
There was a problem hiding this comment.
I think this is already marked as a fixture (a few lines up)?
|
Looks like tests are passing so going to merge. Can follow up if needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.