-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
ENH: read_stata return non-nano #55642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
d7fa43c
ENH: read_stata return non-nano
jbrockmendel fec9cc2
GH ref
jbrockmendel f9598b9
mypy fixup
jbrockmendel dcf0c22
update doctest
jbrockmendel fa3aad7
simplify
jbrockmendel 640aaf9
avoid Series.view
jbrockmendel 2f538c7
dont go through Series
jbrockmendel 7b802c7
move whatsnew
jbrockmendel 303ee6e
Merge branch 'main' into enh-stata-non-nano
jbrockmendel ea261aa
remove outdated whatsnew
jbrockmendel e93dfdb
Merge branch 'main' into enh-stata-non-nano
jbrockmendel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not very familiar with this part of the code base, but this looks like it would overflow when
dates._values
are close to the minimum storage value. Does numpy catch that for us or return junk values?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch. numpy does not catch this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bashtage am i right in thinking stata doesn't support dates millions of years in the past/future so we don't need to worry about these overflows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just did a check of type
tc
and found that the maximum date it would represent is31Dec9999 21:41:39
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This value is stored as
253717911699456