BUG: value_counts returning incorrect dtype for string dtype #55627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
commented
Oct 22, 2023
pandas/core/groupby/groupby.py
Outdated
| @@ -2855,7 +2859,9 @@ def _value_counts( | |||
| result_series.name = name | |||
| result_series.index = index.set_names(range(len(columns))) | |||
| result_frame = result_series.reset_index() | |||
| result_frame.columns = columns + [name] | |||
| result_frame.columns = Index( | |||
| columns + [name], dtype=self.grouper.groupings[0].obj.columns.dtype | |||
There was a problem hiding this comment.
@rhshadrach is there a better way of getting the dtype of the original column index?
There was a problem hiding this comment.
self.obj.columns.dtype I think.
There was a problem hiding this comment.
That's a Series in SeriesGroupBy unfortunately
rhshadrach
requested changes
Oct 24, 2023
|
added a test |
rhshadrach
requested changes
Oct 24, 2023
| ], | ||
| ) | ||
| def test_size_strings(dtype): | ||
| df = DataFrame({"a": ["a", "a", "b"], "b": "a"}, dtype=dtype) |
rhshadrach
added
Algos
|
Thanks @phofl |
|
Sorry for the confusion, this should go into 2.1.2 (it#s only really relevant if you use the new option) |
|
@meeseeksdev backport 2.1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Oct 25, 2023
…type for string dtype
mroeschke
pushed a commit
that referenced
this pull request
Oct 25, 2023
…rect dtype for string dtype) (#55682) Backport PR #55627: BUG: value_counts returning incorrect dtype for string dtype Co-authored-by: Patrick Hoefler <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.