REGR: Groupby methods not supporting numba raising TypeError when the… #55586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… global option is set
lithomas1
added
the
Regression
mroeschke
reviewed
Oct 19, 2023
Nope, we don't have numba support implemented for transforms. |
rhshadrach
reviewed
Oct 24, 2023
pandas/core/groupby/generic.py
Outdated
Comment on lines
242
to
245
| # (if engine is None, the called function will handle the case where | ||
| # numba is requested via the global option) | ||
| kwargs["engine"] = engine | ||
| kwargs["engine_kwargs"] = engine_kwargs |
There was a problem hiding this comment.
If engine is None and engine_kwargs is not None, don't the engine_kwargs end up getting ignored here?
There was a problem hiding this comment.
Ah, I see.
The solution would be to always pass engine_kwargs then?
Since the user has to explicitly do this, then it would be their fault then if they pass in engine_kwargs to a function that doesn't support it.
There was a problem hiding this comment.
As long as engine_kwargs is not None, yes, that sounds right to me.
mroeschke
approved these changes
Oct 25, 2023
|
Thanks @lithomas1 |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Oct 25, 2023
…mba raising TypeError when the…
lithomas1
added a commit
that referenced
this pull request
Oct 25, 2023
…ing numba raising TypeError when the…) (#55686) Backport PR #55586: REGR: Groupby methods not supporting numba raising TypeError when the… Co-authored-by: Thomas Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… global option is set
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.