-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BLD: Pin numpy to < 2 #55488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLD: Pin numpy to < 2 #55488
Conversation
@@ -25,8 +25,8 @@ runs: | |||
- name: Build Pandas | |||
run: | | |||
if [[ ${{ inputs.editable }} == "true" ]]; then | |||
pip install -e . --no-build-isolation -v | |||
pip install -e . --no-build-isolation -v --no-deps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious why do we need the --no-deps flag now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's needed so numpydev can install dev numpy, otherwise the pin will force pip to install 1.26 there which isn't what we want.
Thanks @lithomas1 |
Backport PR #55488: BLD: Pin numpy to < 2 Co-authored-by: Thomas Li <[email protected]>
When NumPy 2.0 does come out, I think doing |
That would probably be a good idea, but I'll let @lithomas1 comment if he has bandwidth to tackle that |
I don't think this is such a good idea. Rebuilding those older versions is likely going to be a PITA, and the gain isn't likely to be worth it. As you might know, this is only going to be an issue for pip (conda has some special mechanism to retroactively apply the pins), so I'm happy telling people to either switch to conda, or follow CI best practices in freezing your package versions. |
From JetBrains 2021 survey, only 21% report using conda. I do not believe it is our role to tell people how they should manage their dependencies.
I don't think there is any data here, but I'd guess from my experience we can't rely on this. Once NumPy 2.0 comes out, users can always specify |
Yeah, I'm totally happy to pin an issue about this. |
I opened #55519. I'll also post something via the pandas Twitter/Mastodon, if I have time, later today. |
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.