BUG: repr of inf values with use_inf_as_na #55483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Oct 11, 2023
| @@ -411,7 +411,7 @@ def test_to_records_with_na_record(self): | |||
| def test_to_records_with_inf_as_na_record(self): | |||
| # GH 48526 | |||
| expected = """ NaN inf record | |||
| 0 NaN b [0, inf, b] | |||
| 0 inf b [0, inf, b] | |||
There was a problem hiding this comment.
If use_inf_as_na is enabled, shouldn't inf still be rendered as NaN?
There was a problem hiding this comment.
No, we still should render the "inf" accurately Notice on L413 that we already do this when the inf is in the columns
mroeschke
approved these changes
Oct 11, 2023
|
Thanks @jbrockmendel |
gupta-paras
pushed a commit
to gupta-paras/pandas
that referenced
this pull request
Oct 12, 2023
* BUG: repr of inf values with use_inf_as_na * GH ref
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The real motivation here is avoiding the special-casing in _format_with_header.
This makes is_float_nan unnecessary, so rips it out.