Skip to content

WEB: Fix rendering of ntv-pandas ecosystem page #55430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 41 commits into from
Oct 9, 2023

Conversation

loco-philippe
Copy link
Contributor

Change rendering bullet list in #55421

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @loco-philippe. I add couple of comments pending from the previous PR.

@datapythonista datapythonista changed the title DOC: Follow-up PR #55421 WEB: Fix rendering of ntv-pandas ecosystem page Oct 7, 2023
@datapythonista datapythonista added the Web pandas website label Oct 7, 2023
@loco-philippe
Copy link
Contributor Author

Sorry, I was not available today.

Thanks @datapythonista for your suggested changes, I agree with all of them.
The commit is done.

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect, thanks @loco-philippe for fixing this so quickly

@mroeschke mroeschke added this to the 2.2 milestone Oct 9, 2023
@mroeschke mroeschke merged commit 42282ce into pandas-dev:main Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Web pandas website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants