REF: formats.format functions that should be DTA methods #55394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Refactor
mroeschke
reviewed
Oct 4, 2023
pandas/core/arrays/datetimes.py
Outdated
Comment on lines
740
to
744
| if date_format is None: | ||
| ido = self._is_dates_only | ||
| if ido: | ||
| # Only dates and no timezone: provide a default format | ||
| date_format = "%Y-%m-%d" |
There was a problem hiding this comment.
Suggested change
| if date_format is None: | |
| ido = self._is_dates_only | |
| if ido: | |
| # Only dates and no timezone: provide a default format | |
| date_format = "%Y-%m-%d" | |
| if date_format is None and self._is_dates_only: | |
| # Only dates and no timezone: provide a default format | |
| date_format = "%Y-%m-%d" |
Nit
There was a problem hiding this comment.
good idea, will update
There was a problem hiding this comment.
#55405 implements this same method in the mixin class TimelikeOps. That is the better long-term location. Will update whichever PR goes in second.
|
updated+green. this and #55405 are blockers for several in-progress branches. |
mroeschke
approved these changes
Oct 4, 2023
|
Thanks @jbrockmendel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.