Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
benchmarks
going to be created or did you meanasv_bench
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not on the pandas repo. It's in the rendered website directory. So, next to
index.html
,about/team.html
... The benchmarks server will be creating and pushing abenchmarks
directory with the html files that asv renders with the results.@DeaMariaLeon and myself will be explaining and documenting all the new benchmark stuff we're building. We'll also be asking what improvements people would like to see in the benchmarks infrastructure once we replicate more or less what we had until now but with our OVH server and a bit simpler way to run things.