DOC: Adjust user guide for CoW docs #55337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| df = pd.DataFrame({"a": [1, 2], "b": [1.5, 2.5]}) | ||
| df.to_numpy() | ||
|
|
||
| The array shares data with the DataFrame if the DataFrame consists of only one NumPy array: |
There was a problem hiding this comment.
Maybe also mention Series here?
| arr = df.to_numpy() | ||
| arr.flags.writeable = True | ||
| arr[0, 0] = 100 | ||
| arr |
There was a problem hiding this comment.
Maybe show df here as well, to show it was updated? Or do we actually not want to show that (since users shouldn't rely on that happening)?
There was a problem hiding this comment.
Yeah I'd prefer not to show this, this example is meant for users that don't care about df anymore
| df.iloc[0, 0] = 100 | ||
|
|
||
| No copy is necessary in this example. | ||
| Creating multiple references in the same method keeps unnecessary references alive |
There was a problem hiding this comment.
I don't understand the "in the same method" here
Co-authored-by: Joris Van den Bossche <[email protected]>
Co-authored-by: Joris Van den Bossche <[email protected]>
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Oct 15, 2023
phofl
added a commit
that referenced
this pull request
Oct 15, 2023
…cs) (#55532) Backport PR #55337: DOC: Adjust user guide for CoW docs Co-authored-by: Patrick Hoefler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly from my blog post, would like to backport this ideally.