DOC: add parameters and examples to CustomBusinessMonthBegin/End #55328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natmokval
changed the title
MarcoGorelli
suggested changes
Oct 1, 2023
pandas/_libs/tslibs/offsets.pyx
Outdated
Comment on lines
4461
to
4463
| _attributes = tuple( | ||
| ["n", "normalize", "weekmask", "holidays", "calendar", "offset"] | ||
| ) |
There was a problem hiding this comment.
ok with moving the docstring, but I think _attributes could have stayed in the parent class? could we move that back please to remove duplication?
There was a problem hiding this comment.
Thank you for reviewing this PR. I moved _attributes to _CustomBusinessMonth
MarcoGorelli
approved these changes
Oct 1, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the documentation of offsets classes: CustomBusinessMonthEnd and CustomBusinessMonthBegin there are no parameters, see also and examples sections. I added parameters and examples.