Skip to content

CLN: Clean up some iteration logic in tslib #55320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2023
Merged

CLN: Clean up some iteration logic in tslib #55320

merged 1 commit into from
Sep 29, 2023

Conversation

lithomas1
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@lithomas1 lithomas1 marked this pull request as ready for review September 28, 2023 23:23
@lithomas1 lithomas1 requested a review from WillAyd as a code owner September 28, 2023 23:23
@lithomas1
Copy link
Member Author

I don't think the multi-iterator is necessary, we only iterate on values not results.

cc @jbrockmendel

WillAyd
WillAyd reviewed Sep 29, 2023
View reviewed changes
@jbrockmendel jbrockmendel merged commit 8f20e82 into pandas-dev:main Sep 29, 2023
@jbrockmendel
Copy link
Member

thanks @lithomas1

@lithomas1 lithomas1 deleted the cln-tslib branch September 29, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

@jbrockmendel jbrockmendel jbrockmendel approved these changes

Assignees
No one assigned
Labels
Clean
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lithomas1 @jbrockmendel @WillAyd