Skip to content

ENH: case_when function #55306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 19 commits into from
Closed

ENH: case_when function #55306

wants to merge 19 commits into from

Conversation

samukweku
Copy link
Contributor

@samukweku samukweku commented Sep 27, 2023

Continues the work started by @ELHoussineT(#50343)

  • uses pd.Series.mask under the hood
  • function implementation, as well as a Series method

@samukweku samukweku changed the title Samukweku/case when [ENH] case_when function Sep 27, 2023
@samukweku samukweku changed the title [ENH] case_when function ENH: case_when function Sep 28, 2023
@samukweku
Copy link
Contributor Author

Hi @mroeschke @rhshadrach @phofl can I pls get some feedback on this PR. thanks

@Dr-Irv
Copy link
Contributor

Dr-Irv commented Oct 3, 2023

Please merge with current main. Your PR is deleting code recently merged.

@samukweku
Copy link
Contributor Author

@Dr-Irv thanks for the feedback. I have merged with current main - i still notice extra files that shouldnt pop up for review, since it has nothing to do with this PR. open to suggestions on how to fix this. thanks

@Dr-Irv
Copy link
Contributor

Dr-Irv commented Oct 3, 2023

@Dr-Irv thanks for the feedback. I have merged with current main - i still notice extra files that shouldnt pop up for review, since it has nothing to do with this PR. open to suggestions on how to fix this. thanks

I don't think you did it correctly. I am just looking at _typing.py, and it shows you deleted stuff.

Do

git fetch upstream
git merge upstream/main
git push origin case_when

@samukweku
Copy link
Contributor Author

thanks @Dr-Irv i will close this PR, I created a new one - hopefully the issues wont resurface. #55390

@samukweku samukweku closed this Oct 4, 2023
@Dr-Irv
Copy link
Contributor

Dr-Irv commented Oct 4, 2023

thanks @Dr-Irv i will close this PR, I created a new one - hopefully the issues wont resurface. #55390

I looked briefly, and see that the issue is gone. But others will need to approve that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: Dedicated method for creating conditional columns
2 participants