CLN: Remove temp_setattr from groupby.transform #55262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

rhshadrach merged 1 commit into pandas-dev:main from rhshadrach:gb_transform_remove_observed_hack

Sep 24, 2023

+7 −9

Member

rhshadrach commented Sep 24, 2023

closes #xxxx (Replace xxxx with the GitHub issue number)
Tests added and passed if fixing a bug or adding a new feature
All code checks passed.
Added type annotations to new arguments/methods/functions.
Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Using temp_setattr doesn't actually change anything. All of the objects that observed impacts are cached and have already been computed.


          CLN: Remove temp_setattr from groupby.transform

a648e89

rhshadrach added Groupby Clean labels

Member

jbrockmendel commented Sep 24, 2023

nice! LGTM pending green

rhshadrach added this to the 2.2 milestone

rhshadrach merged commit d01669f into pandas-dev:main

rhshadrach deleted the gb_transform_remove_observed_hack branch

September 24, 2023 17:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels