StataWriter: Replace non-isalnum characters in variable names by _ inste... #5525
+75
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this looks fine, can you add a release notes entry? |
…stead of integral represantation of replaced character. Eliminate duplicates created by replacement.
|
Done. |
jreback
added a commit
that referenced
this pull request
Dec 4, 2013
StataWriter: Replace non-isalnum characters in variable names by _ inste...
|
I had to revert this commit This fails on win32 with python2.6, because of the unicode in the source file you can do something like this (but then the test breaks) https://github.com/pydata/pandas/tree/stata_fix pls submit a new PR with the fixed version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ad of integral represantation of replaced character. Eliminate duplicates created by replacement.