-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: Interchange object data buffer has the wrong dtype / from_dataframe incorrect #55227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MarcoGorelli
merged 11 commits into
pandas-dev:main
from
MarcoGorelli:use-buffer-dtype-in-from-dataframe
Nov 7, 2023
Merged
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
9876c64
use buffer dtype in interchange from_dataframe
MarcoGorelli 0b936b3
Merge remote-tracking branch 'upstream/main' into use-buffer-dtype-in…
MarcoGorelli 00ad9c7
wip
MarcoGorelli d54f950
wip
MarcoGorelli adeceb9
add failing test
MarcoGorelli 3557b4a
wip
MarcoGorelli 975c87c
Merge remote-tracking branch 'upstream/main' into use-buffer-dtype-in…
MarcoGorelli 0ef179a
simplify
MarcoGorelli df996ac
remove unnecessary assertion
MarcoGorelli 0bea19b
dont double-extract bit width
MarcoGorelli d04ac92
Update pandas/core/interchange/from_dataframe.py
MarcoGorelli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We unpack
col.dtype
on line 381, it'll be slightly more efficient to get the bit width from there!