-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CLN: Add more methods to whitelist (for now) #5514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
"for now" ? |
As in, do it for 0.13 and then figure out about adding test cases and |
ok, sweet. I wonder if these are low hanging fruit for vector / cythoning. |
@jtratner what's the status of thsi? |
I have a branch with a tentative PR that I can submit later today. One hitch found while testing is that the whitelist is used for groupby tab
|
I'd be inclined to just leave it for both...once you try to use it you'll |
The other option is to add it in the Series/DataFrameGroupby class rather than to the whitelist. |
closing in favor of #5604 |
No test cases because goal is just to make sure this is not blocked in
0.13. Can do more tweaks later. If I have time I will try to pull
together something to cover what we were discussing in #5480.