BUG: This fixes #55009 (raw=True caused apply method of DataFrame to ignore passed arguments)
#55089
+9
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # doc/source/whatsnew/v2.2.0.rst
mroeschke
reviewed
Sep 11, 2023
Co-authored-by: Matthew Roeschke <[email protected]>
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
mroeschke
approved these changes
Sep 13, 2023
|
Thanks @martin-sicho |
hedeershowk
pushed a commit
to hedeershowk/pandas
that referenced
this pull request
Sep 20, 2023
… `DataFrame` to ignore passed arguments) (pandas-dev#55089) * fixes pandas-dev#55009 * update documentation * write documentation * add test * change formatting * cite DataDrame directly in docs Co-authored-by: Matthew Roeschke <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: Matthew Roeschke <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
hedeershowk
pushed a commit
to hedeershowk/pandas
that referenced
this pull request
Sep 20, 2023
… `DataFrame` to ignore passed arguments) (pandas-dev#55089) * fixes pandas-dev#55009 * update documentation * write documentation * add test * change formatting * cite DataDrame directly in docs Co-authored-by: Matthew Roeschke <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: Matthew Roeschke <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
|
@mroeschke Hi, could you please consider making this fix available sooner, perhaps in the next patch release? I believe that using |
mroeschke
added a commit
that referenced
this pull request
Sep 27, 2023
* add pyarrow autogenerated prefix * whats new bug fix * test with no head and pyarrow * only test pyarrow * BUG: This fixes #55009 (`raw=True` caused `apply` method of `DataFrame` to ignore passed arguments) (#55089) * fixes #55009 * update documentation * write documentation * add test * change formatting * cite DataDrame directly in docs Co-authored-by: Matthew Roeschke <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: Matthew Roeschke <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * PR review feedback * Update doc/source/whatsnew/v2.2.0.rst Co-authored-by: Matthew Roeschke <[email protected]> * alphabetical whatsnew --------- Co-authored-by: Martin Šícho <[email protected]> Co-authored-by: Matthew Roeschke <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #55009. I documented the fix and also added some code to the tests that should pick it up next time.
Unfortunately, I was not able to run the tests manually yet with this error:
I probably do not have something properly installed. So let me know if I should run them in addition to what is done on the CI pipelines.
Checklist
DataFrame.applymethod does not use the extra argument list whenraw=True#55009doc/source/whatsnew/vX.X.X.rstfile