-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Revert "BUG: Timestamp origin takes no effect in resample for 'MS' frequency (#53938)" #55077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…equency (pandas-dev#53938)" This reverts commit dfc4c39.
mroeschke
reviewed
Oct 2, 2023
doc/source/whatsnew/v2.1.1.rst
Outdated
@@ -20,6 +20,7 @@ Fixed regressions | |||
- Fixed regression in :meth:`.GroupBy.get_group` raising for ``axis=1`` (:issue:`54858`) | |||
- Fixed regression in :meth:`DataFrame.__setitem__` raising ``AssertionError`` when setting a :class:`Series` with a partial :class:`MultiIndex` (:issue:`54875`) | |||
- Fixed regression in :meth:`DataFrame.filter` not respecting the order of elements for ``filter`` (:issue:`54980`) | |||
- Fixed regression in :meth:`DataFrame.resample` which was extrapolating back to ``origin`` when ``origin`` was outside its bounds (:issue:`55064`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need to be moved to 2.1.2 now
mroeschke
approved these changes
Oct 9, 2023
Thanks @MarcoGorelli |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Oct 9, 2023
…effect in resample for 'MS' frequency (pandas-dev#53938)"
MarcoGorelli
added a commit
that referenced
this pull request
Oct 24, 2023
…es no effect in resample for 'MS' frequency (#53938)") (#55459) * Backport PR #55077: Revert "BUG: Timestamp origin takes no effect in resample for 'MS' frequency (#53938)" * fixup doctest * noop * fixup doctests --------- Co-authored-by: Marco Edward Gorelli <[email protected]> Co-authored-by: MarcoGorelli <[email protected]> Co-authored-by: Thomas Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #55064
This reverts commit dfc4c39.
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.I'm just:
origin
only takes effect for tick-frequenciesand adding a 2.1.1 whatsnew note