Minor change to CleanCommand so build works with stdeb #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesm
added a commit
that referenced
this pull request
Jun 29, 2011
Minor change to CleanCommand so build works with stdeb
|
Looks fine to me. Thanks for the patch! |
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Wes, i've been following your pandas work for a while, and regularly install it on my ubuntu based systems. I generally use the stdeb (https://github.com/astraw/stdeb) package for creating .deb files from python packages. Unfortunately, some of your recent changes in setup.py in pandas caused a problem with building using stdeb. Essentially the problem is that debhelper tries to run "python setup.py clean -a" at some point, which doesn't work because the customized clean command does not have a "-a" option. I just added a dummy argument "--all, -a" argument that has no effect.
No worries if you'd rather not merge it, just wanted to check.
thanks