Skip to content

Include pyarrow_numpy string in efficient merge implementation #54974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2023
Merged

Include pyarrow_numpy string in efficient merge implementation #54974

merged 1 commit into from
Sep 5, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Sep 2, 2023

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@phofl phofl added Performance Memory or execution speed performance Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Sep 2, 2023
@phofl phofl added this to the 2.1.1 milestone Sep 2, 2023
mroeschke
mroeschke approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it need a whatsnew?

@phofl
Copy link
Member Author

phofl commented Sep 5, 2023

I wouldn't add a whatsnew, not widely enough used that it would really matter I think

@mroeschke mroeschke merged commit 1b3ebe4 into pandas-dev:main Sep 5, 2023
@mroeschke
Copy link
Member

Thanks @phofl

@meeseeksmachine meeseeksmachine mentioned this pull request Sep 5, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Sep 5, 2023
@phofl @meeseeksmachine
Backport PR pandas-dev#54974: Include pyarrow_numpy string in efficie…
0d3e86e 
…nt merge implementation
@phofl phofl deleted the merge_pyarrow_numpy branch September 5, 2023 22:39
mroeschke pushed a commit that referenced this pull request Sep 6, 2023
@meeseeksmachine @phofl
Backport PR #54974 on branch 2.1.x (Include pyarrow_numpy string in e…
b736912 
…fficient merge implementation) (#55021)

Backport PR #54974: Include pyarrow_numpy string in efficient merge implementation

Co-authored-by: Patrick Hoefler <[email protected]>
mroeschke pushed a commit to mroeschke/pandas that referenced this pull request Sep 11, 2023
@phofl @mroeschke
Include pyarrow_numpy string in efficient merge implementation (panda…
a83511f 
…s-dev#54974)

Inlude pyarrow_numpy string in efficient merge implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Performance Memory or execution speed performance Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Milestone
2.1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@phofl @mroeschke