TST: Use (unused) window parameter of test_freq_window_not_implemented #54947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Sep 5, 2023
pandas/core/indexers/objects.py
Outdated
| @@ -208,7 +208,9 @@ def get_window_bounds( | |||
| step: int | None = None, | |||
| ) -> tuple[np.ndarray, np.ndarray]: | |||
| if step is not None: | |||
| raise NotImplementedError("step not implemented for variable offset window") | |||
| raise NotImplementedError( | |||
| "step is not supported with variable offset window" | |||
There was a problem hiding this comment.
Could you keep this message unchanged?
mroeschke
approved these changes
Sep 6, 2023
|
Thanks @ihsansecer |
mroeschke
pushed a commit
to mroeschke/pandas
that referenced
this pull request
Sep 11, 2023
pandas-dev#54947) * Use window parameter of test_freq_window_not_implemented * Revert change in exception message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Realized that
windowparameter is unused so this is fixing it. Callingsumfunction as the exception is only raised when a function is called withVariableOffsetWindowIndexer. Not sure if I need to add an entry to whatsnew for thisdoc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.