Skip to content

Convert test_sql to pytest idiom #54936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 7, 2023
Merged

Convert test_sql to pytest idiom #54936

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
75910dd
Convert test_sql to pytest idiom
WillAyd Sep 1, 2023
bcff47f
Try KeyError catch
WillAyd Sep 5, 2023
701989a
Added drop_view to existing test method
WillAyd Sep 5, 2023
75bb2a9
Merge branch 'main' into refactor-test-sql
WillAyd Sep 6, 2023
922bcde
xfail MySQL issue
WillAyd Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pandas/io/sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ def _parse_date_columns(data_frame, parse_dates):
if isinstance(df_col.dtype, DatetimeTZDtype) or col_name in parse_dates:
try:
fmt = parse_dates[col_name]
except TypeError:
except (KeyError, TypeError):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't reproduce this locally but it seems like this code didn't like the case when DateColWithTz was inferred to be temporal and was not included in parse_dates

fmt = None
data_frame.isetitem(i, _handle_date_column(df_col, format=fmt))

Expand Down
Loading