REGR: value_counts raises with bins #54884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
Regression
mroeschke
reviewed
Aug 31, 2023
pandas/tests/test_algos.py
Outdated
| # GH#54857 | ||
| values = np.array([3, 1, 2, 3, 4, np.nan]) | ||
| with tm.assert_produces_warning(FutureWarning, match="deprecated"): | ||
| result = pd.value_counts(values, bins=3) |
There was a problem hiding this comment.
Can we just test the pd.Series(values).values_counts(bins=3) version instead to avoid the futurewarning?
There was a problem hiding this comment.
Edit: Sorry that was wrong, wrong environment, yes can do
mroeschke
approved these changes
Aug 31, 2023
# Conflicts: # doc/source/whatsnew/v2.1.1.rst
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Sep 1, 2023
mroeschke
pushed a commit
that referenced
this pull request
Sep 1, 2023
…ns) (#54932) Backport PR #54884: REGR: value_counts raises with bins Co-authored-by: Patrick Hoefler <[email protected]>
mroeschke
pushed a commit
to mroeschke/pandas
that referenced
this pull request
Sep 11, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.