REGR: read_csv raising when dtypes is specified with usecols #54881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
Regression
mroeschke
reviewed
Aug 31, 2023
pandas/io/parsers/python_parser.py
Outdated
| @@ -1176,7 +1176,7 @@ def _set_no_thousand_columns(self) -> set[int]: | |||
| ) | |||
| if self.columns and self.dtype: | |||
| assert self._col_indices is not None | |||
| for i in self._col_indices: | |||
| for i, idx in enumerate(self._col_indices): | |||
There was a problem hiding this comment.
Suggested change
| for i, idx in enumerate(self._col_indices): | |
| for i, col in zip(self._col_indices, self.columns): |
and then self.columns[i] can just be replaced with col?
mroeschke
approved these changes
Aug 31, 2023
|
Thanks @phofl |
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
phofl
added a commit
to phofl/pandas
that referenced
this pull request
Sep 1, 2023
…dev#54881) * REGR: read_csv raising when dtypes is specified with usecols * Update * Add whatsnew (cherry picked from commit 75781c2)
phofl
added a commit
that referenced
this pull request
Sep 1, 2023
…s is specified with usecols) (#54926)
mroeschke
pushed a commit
to mroeschke/pandas
that referenced
this pull request
Sep 11, 2023
…dev#54881) * REGR: read_csv raising when dtypes is specified with usecols * Update * Add whatsnew
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IndexError: list index out of rangewhen usingdtypeandusecolsparameters #54868 (Replace xxxx with the GitHub issue number)doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.