-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
ENH: Bring devcontainer
closer to GitHub CI environment, improve vscode
setup
#54845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Bring devcontainer
closer to GitHub CI environment, improve vscode
setup
#54845
Conversation
…ad of deprecated ones.
…d up automatically.
…about unsupported command line argument triggered by `redefined-loop-name` in `pyproject.toml`.
I see the check It did not previously because the old So I see two approaches here:
The second approach would be quite a bit more involved I think, as I don't think there is an established Docker publication infrastructure in |
I would recommend you open an issue about this first before moving further with this PR, the Dockerfile for example used to be closer to what you had but it was deemed to large/slow to build and it was slimmed down. It would be good to discuss in an issue since it might also break people's workflows |
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.This PR serves two purposes:
GitHub Actions use
micromamba
for Python environment management, while the old devcontainer setup used to usepip
(with a list of dependencies fetched fromrequirements-dev.txt
once at container image creation).As I was trying to reproduce an unrelated issue locally, I was unsure whether deviations from the CI reults may have been caused by different Python environments. This change should reduce uncertainties in this regard.
This PR attempts to produce a devcontainer that has high utility out of the box (e.g., installation and configuration of extensions for
mypy
,flake8
,black
, etc.)Furthermore, it replaces deprecated configuration options with the preferred ones.
If you like this PR, please let me know which
whatsnew
file this should be mentioned in (v2.1.0.rst
I presume?)Also, do you need me to open an issue for this?