BUG: ArrowExtensionArray.to_numpy avoid object dtype when na_value provided #54843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lukemanley
commented
Aug 29, 2023
lukemanley
commented
- closes BUG: avoid conversion to object dtype in to_numpy for Arrow dtype and with dtype-compatible fill value #54808
- Tests added and passed if fixing a bug or adding a new feature
- All code checks passed.
- Added type annotations to new arguments/methods/functions.
mroeschke
reviewed
Aug 31, 2023
pandas/core/arrays/arrow/array.py
Outdated
| result[self.isna()] = na_value | ||
| else: | ||
| if dtype is None: | ||
| empty = data._pa_array[:0].to_numpy() |
There was a problem hiding this comment.
I think data.dtype.empty._pa_array would be a "nicer" way to get an empty example to use in can_hold_element
mroeschke
reviewed
Aug 31, 2023
pandas/core/arrays/arrow/array.py
Outdated
| if data._hasna: | ||
| result[data.isna()] = na_value | ||
| elif pa.types.is_null(pa_type): | ||
| if dtype is not None and dtype.kind != "O" and isna(na_value): |
There was a problem hiding this comment.
Why do we need to skip object here?
There was a problem hiding this comment.
removed it, not needed
mroeschke
approved these changes
Sep 1, 2023
|
Thanks @lukemanley |
mroeschke
pushed a commit
to mroeschke/pandas
that referenced
this pull request
Sep 11, 2023
…ovided (pandas-dev#54843) * ENH: ArrowExtensionArray.to_numpy to avoid object dtype when na_value provided * refactor * cleanup * mypy * fix
Open
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.