Skip to content

DOC: Removing repeated NA #54821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 29, 2023
Merged

DOC: Removing repeated NA #54821

merged 10 commits into from
Sep 29, 2023

Conversation

DeaMariaLeon
Copy link
Member

@DeaMariaLeon
Copy link
Member Author

/preview

@github-actions
Copy link
Contributor

No preview found for PR #54821. Did the docs build complete?

@DeaMariaLeon DeaMariaLeon marked this pull request as ready for review August 29, 2023 12:54
@DeaMariaLeon
Copy link
Member Author

@MarcoGorelli
I'm trying to do what you suggested about this issue but I'm missing something. Would you mind taking a look please? thanks

@MarcoGorelli
Copy link
Member

thanks - looks like there's a CI failure, but I'm hoping it's unrelated - have tried merging upstream/main, let's see

@MarcoGorelli
Copy link
Member

/preview

@github-actions
Copy link
Contributor

No preview found for PR #54821. Did the docs build complete?

@MarcoGorelli
Copy link
Member

I downloaded the docs build, and it looks fine - what were you referring to when you wrote "but I'm missing something"?

Only comment I have is that NaT is also repeated, and that if we're going to have a missing values section, then I think that should also be moved there together with NA?

@DeaMariaLeon
Copy link
Member Author

I wrote "but I'm missing something" because the preview didn't work. I thought that there was an error on what I did. I'll add the NaT to the section then. Thanks

@DeaMariaLeon
Copy link
Member Author

/preview

@github-actions
Copy link
Contributor

No preview found for PR #54821. Did the docs build complete?

@DeaMariaLeon
Copy link
Member Author

I downloaded the docs build

Hey @MarcoGorelli, how did you do that? (I tried and couldn't find it).

@MarcoGorelli
Copy link
Member

hey - if you click on https://github.com/pandas-dev/pandas/actions/runs/6341541518/job/17225406933?pr=54821 and then "summary", at the bottom of the page it says "artifacts"

you can download then, extract it, and then from python3 -m http.server from inside (I think from the docs folder), and then open localhost:8000 in your browser

@DeaMariaLeon
Copy link
Member Author

Thanks @MarcoGorelli.
Now, is this OK? :

Screenshot 2023-09-29 at 12 50 39

@MarcoGorelli MarcoGorelli added this to the 2.2 milestone Sep 29, 2023
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one, thanks for doing this!

@MarcoGorelli MarcoGorelli merged commit c8e7a98 into pandas-dev:main Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: pandas.NA repeated on website
2 participants