REGR: Index.union loses python string dtype #54778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Aug 27, 2023
Co-authored-by: Matthew Roeschke <[email protected]>
Closed
| @@ -5194,7 +5194,7 @@ def _from_join_target(self, result: np.ndarray) -> ArrayLike: | |||
| """ | |||
| if isinstance(self.values, BaseMaskedArray): | |||
| return type(self.values)(result, np.zeros(result.shape, dtype=np.bool_)) | |||
| elif isinstance(self.values, ArrowExtensionArray): | |||
| elif isinstance(self.values, (ArrowExtensionArray, StringArray)): | |||
There was a problem hiding this comment.
just out of interest, why can't this be done for all EAs?
There was a problem hiding this comment.
We enhanced this when we added _get_join_target. Previously we returned result unchanged, so not sure if this would potentially break stuff
There was a problem hiding this comment.
ok - this looks fine to be, but would prefer if someone more familiar with core/indexes could take a look too
mroeschke
approved these changes
Aug 28, 2023
|
Thanks @phofl |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Aug 28, 2023
mroeschke
pushed a commit
that referenced
this pull request
Aug 28, 2023
…ring dtype) (#54813) Backport PR #54778: REGR: Index.union loses python string dtype Co-authored-by: Patrick Hoefler <[email protected]>
mroeschke
added a commit
to mroeschke/pandas
that referenced
this pull request
Sep 11, 2023
* REGR: Index.union loses python string dtype * Update pandas/core/indexes/base.py Co-authored-by: Matthew Roeschke <[email protected]> --------- Co-authored-by: Matthew Roeschke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.cc @mroeschke