-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: merge raising for ea int and numpy float #54755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
if is_extension_array_dtype(lk.dtype) and not is_extension_array_dtype( | ||
rk.dtype | ||
): | ||
ct = find_common_type([lk.dtype, rk.dtype]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we know that this will always return an ExtensionDtype
? Might be good to first check that it is one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah one more check won't hurt. Updated
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
Thanks @phofl |
* BUG: merge raising for ea int and numpy float * Fix up mypy and add check (cherry picked from commit 9939c32)
* BUG: merge raising for ea int and numpy float * Fix up mypy and add check
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.Ideally I'd like to get this in, but not a blocker