Revert deprecation of con as keyword only arg #54750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lithomas1
approved these changes
Aug 25, 2023
mroeschke
reviewed
Aug 25, 2023
| ) | ||
| df = DataFrame([{"A": 1, "B": 2, "C": 3}, {"A": 1, "B": 2, "C": 3}]) | ||
| df.to_sql("example", self.conn) |
There was a problem hiding this comment.
Suggested change
| df.to_sql("example", self.conn) |
Don't think this is needed?
There was a problem hiding this comment.
I’d like to keep it to keep a test that this does not raise close by
There was a problem hiding this comment.
Ah okay. I think you'll need a if_exists="replace" below then.
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Aug 26, 2023
phofl
added a commit
that referenced
this pull request
Aug 26, 2023
…ord only arg) (#54766) Backport PR #54750: Revert deprecation of con as keyword only arg Co-authored-by: Patrick Hoefler <[email protected]>
mroeschke
pushed a commit
to mroeschke/pandas
that referenced
this pull request
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
conas positional onto_sql#54749 (Replace xxxx with the GitHub issue number)doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.