TST: win32 fixes #5474
Merged
TST: win32 fixes #5474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1344,7 +1344,7 @@ def test_inplace_mutation_resets_values(self): | |||
|
|
|||
| # make sure label setting works too | |||
| labels2 = [[0, 0, 0, 0, 0, 0], [0, 0, 0, 0, 0, 0]] | |||
| exp_values = np.array([(1, 'a')] * 6, dtype=object) | |||
| exp_values = np.array([(1L, 'a')] * 6, dtype=object) | |||
There was a problem hiding this comment.
can't remember if this works in Python 3, but if it doesn't, import long from compat.
There was a problem hiding this comment.
yep...had to add that
|
so do you have any sense of why these issues occur? Just 32 bit issues? specific to windows? Just want to be able to keep in mind in the future. |
|
@jtratner these are all because the tests on a 32-bit windows default with int32 for numpy arange (so the tests are wrong), e.g. in this case numpy creates these as 32-bit integers but they are really 64-bit in the implementation |
|
Can we add a 32bit Travis build? Would that help? |
|
I think that travis was using 32-bit builds...now seem 64-bit.... it DOES help catch stuff (though this is really windows specific oddities) |
TST don't compare invalid indices in eval operations (GH5467) TST: invalid assignment for np.timedelta64 (GH5465) TST: skip locale checks on windows (GH5464) TST: dtype comp issue on windows in test_indexing (GH5466) TST: skip test_pow on windows (GH5467)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TST: test_indexing dtype comps, closes #5466
TST don't compare invalid indices in eval operations, closes #5467
TST: invalid assignment for np.timedelta64 closes #5465
TST: skip locale checks on windows cloes #5464
TST: dtype comp issue on windows in test_indexing (GH5466)
TST: skip test_pow on windows (GH5467)