Skip to content

TYP: Return type for eq/ne/div/... #54725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 24, 2023
Merged

TYP: Return type for eq/ne/div/... #54725

merged 1 commit into from
Aug 24, 2023

Conversation

twoertwein
Copy link
Member

@twoertwein twoertwein commented Aug 24, 2023

I was first trying to use Self (not sure whether it should be used here) but that seems to confuse mypy when the method is assigned to an alias (e.g., subtract = sub) as it then seems to loose track of what Self refers to.

@twoertwein twoertwein added the Typing type annotations, mypy/pyright type checking label Aug 24, 2023
@mroeschke mroeschke added this to the 2.2 milestone Aug 24, 2023
@mroeschke mroeschke merged commit 2bf1df9 into pandas-dev:main Aug 24, 2023
@mroeschke
Copy link
Member

Thanks @twoertwein

@twoertwein twoertwein deleted the operators branch September 19, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants