Skip to content

DEPR: downcasting in replace #54710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 18, 2023

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@@ -659,6 +659,7 @@ Pass nested dictionaries of regular expressions that use the ``regex`` keyword.
Pass a list of regular expressions that will replace matches with a scalar.

.. ipython:: python
:okwarning:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can these examples be changed to not produce a warning?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated to not produce warning + green

@mroeschke mroeschke added this to the 2.2 milestone Sep 18, 2023
@mroeschke mroeschke added the Deprecate Functionality to remove in pandas label Sep 18, 2023
@mroeschke mroeschke merged commit 95b6057 into pandas-dev:main Sep 18, 2023
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the depr-replace-coerce branch September 18, 2023 17:44
hedeershowk pushed a commit to hedeershowk/pandas that referenced this pull request Sep 20, 2023
* DEPR: downcasting in replace

* GH refs

* fix docbuild i hope

* suppress doc warnings

* avoid warning in docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants