TST: added test for fixed bug gh#50372 #54701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Aug 23, 2023
| @@ -1252,6 +1252,22 @@ def test_type_error_multiindex(self): | |||
| result = dg["x", 0] | |||
| tm.assert_series_equal(result, expected) | |||
|
|
|||
| def test_tuple_string_column_names(self): | |||
There was a problem hiding this comment.
Can you move this to pandas/tests/indexing/multiindex/test_getitem.py?
mroeschke
reviewed
Aug 23, 2023
|
|
||
| df_flat = df_flat[[("a", "aa"), "new_single_index"]] | ||
|
|
||
| assert df_flat.columns.equals(Index([("a", "aa"), "new_single_index"])) |
There was a problem hiding this comment.
Can you construct the full pandas object result of df_flat and use tm.assert_equal?
result = df_flat[[("a", "aa"), "new_single_index"]]
expected = ...
tm.assert_equal(result, expected)
There was a problem hiding this comment.
Also done (: @mroeschke
mroeschke
added
the
Testing
mroeschke
approved these changes
Aug 23, 2023
|
Thanks @DRiXD |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a test to prevent the bug described in GG#50372 from happening again.