Skip to content

REF: use single-test-class for datetimetz, period tests #54676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 22, 2023

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@mroeschke mroeschke added the Testing pandas testing functions or related to the test suite label Aug 21, 2023
@mroeschke
Copy link
Member

mypy.....................................................................Failed
- hook id: mypy
- duration: 127.2s
- exit code: 1

pandas/tests/extension/test_period.py:95: error: Item "dtype[Any]" of "dtype[Any] | ExtensionDtype" has no attribute "freq"  [union-attr]
pandas/tests/extension/test_period.py:95: error: Item "ExtensionDtype" of "dtype[Any] | ExtensionDtype" has no attribute "freq"  [union-attr]
pandas/tests/extension/test_datetime.py:131: error: Item "dtype[Any]" of "dtype[Any] | ExtensionDtype" has no attribute "tz"  [union-attr]
pandas/tests/extension/test_datetime.py:131: error: Item "ExtensionDtype" of "dtype[Any] | ExtensionDtype" has no attribute "tz"  [union-attr]
Found 4 errors in 2 files (checked 1413 source files)

@jbrockmendel
Copy link
Member Author

updated+green

@mroeschke mroeschke added this to the 2.2 milestone Aug 22, 2023
@mroeschke mroeschke merged commit 5459d10 into pandas-dev:main Aug 22, 2023
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the tst-one-class-3 branch August 22, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants