BUG: drop_duplicates raising for boolean arrow dtype with missing values #54670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # doc/source/whatsnew/v2.1.0.rst
mroeschke
reviewed
Aug 21, 2023
| @@ -249,3 +249,10 @@ def test_drop_duplicates_ignore_index(self): | |||
| result = ser.drop_duplicates(ignore_index=True) | |||
| expected = Series([1, 2, 3]) | |||
| tm.assert_series_equal(result, expected) | |||
|
|
|||
| def test_duplicated_arrow_dtype(keep): | |||
There was a problem hiding this comment.
Did you intend to parameterize over keep?
There was a problem hiding this comment.
Nope, that was a lesson that you shouldn't copy paste without double checking
Since Arrow support isn't new anymore I suppose we shouldn't be backporting bug fixes as aggressively anymore, but I would still be okay with it |
|
Ok then maybe lets backport low risk fixes and decide on the others on a case by case basis |
mroeschke
approved these changes
Aug 22, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Aug 22, 2023
…n arrow dtype with missing values
|
Thanks @phofl |
mroeschke
pushed a commit
that referenced
this pull request
Aug 22, 2023
…boolean arrow dtype with missing values) (#54692) Backport PR #54670: BUG: drop_duplicates raising for boolean arrow dtype with missing values Co-authored-by: Patrick Hoefler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.cc @mroeschke
More generally, how do we want to proceed with Arrow EA fixes after 2.1 is out?