Skip to content

BUG: _apply_rule() ignores tz info on an empty list of observances #54655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Aug 22, 2023
Merged

BUG: _apply_rule() ignores tz info on an empty list of observances #54655

merged 12 commits into from
Aug 22, 2023

Conversation

roadswitcher
Copy link
Contributor

@roadswitcher roadswitcher commented Aug 21, 2023 •
edited
Loading

@roadswitcher
Copy link
Contributor Author

This seemed eerily familar -- reminded me of #49075.

Figured out that _apply_rule() was silently ignoring the timezone data if you passed it an empty list of holiday observances that were computed given start and end dates that had timezone info.

@amithkk amithkk mentioned this pull request Aug 21, 2023
Closed
2 tasks
@roadswitcher roadswitcher changed the title _apply_rule() ignores tz info on an empty list of observances BUG: _apply_rule() ignores tz info on an empty list of observances Aug 21, 2023
@mroeschke mroeschke added the Timezones Timezone data dtype label Aug 21, 2023
@mroeschke mroeschke added this to the 2.2 milestone Aug 22, 2023
@mroeschke mroeschke merged commit 8dd045d into pandas-dev:main Aug 22, 2023
@mroeschke
Copy link
Member

Thanks @roadswitcher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Timezones Timezone data dtype
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.

BUG: USFederalHolidayCalendar().holiday() call fails before 2018
2 participants
@roadswitcher @mroeschke