DOC: Add information on fetching tags for contributors building pandas. #54618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
approved these changes
Aug 18, 2023
mroeschke
reviewed
Aug 18, 2023
| @@ -228,6 +228,14 @@ To compile pandas with meson, run:: | |||
| # If you do not want to see this, omit everything after --no-build-isolation | |||
| python -m pip install -ve . --no-build-isolation --config-settings editable-verbose=true | |||
|
|
|||
| .. note:: | |||
| The version number is pulled from the latest repository tag. Be sure to fetch the latest tags from upstream | |||
| before building:: | |||
There was a problem hiding this comment.
Can you use code-block:: shell instead of ::?
There was a problem hiding this comment.
@mroeschke FWIW, the code block just above with the install command also uses ::, so I think the current version is fine here to keep it consistent.
(if we want to generally move to use code-block:: shell, it might be better to first do a PR to change it consistently in the full file?)
There was a problem hiding this comment.
Okay sure this can be a follow up
mroeschke
approved these changes
Aug 18, 2023
|
Thanks @stefmolin |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.