TST: annotations, fix test_invert #54576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Aug 16, 2023
pandas/tests/extension/base/ops.py
Outdated
| expected = pd.Series(~data, name="name") | ||
| tm.assert_series_equal(result, expected) | ||
| try: | ||
| [~x for x in data] |
There was a problem hiding this comment.
Maybe for x in data.unique(): ~x so we process and minimize collecting values.
Also should the data.dtype.na_value be skipped when trying invert?
There was a problem hiding this comment.
ill just make it data[:10]. if ~na_value raises im not sure what id expect ~data to do, so prefer to leave that as is
mroeschke
added
Testing
mroeschke
reviewed
Aug 16, 2023
| @@ -18,6 +18,7 @@ | |||
|
|
|||
| from pandas.core.dtypes.dtypes import IntervalDtype | |||
|
|
|||
| import pandas as pd | |||
There was a problem hiding this comment.
Good to put in if TYPE_CHECKING?
mroeschke
approved these changes
Aug 17, 2023
|
Thanks @jbrockmendel |
mroeschke
pushed a commit
to mroeschke/pandas
that referenced
this pull request
Aug 18, 2023
* TST: annotations, fix test_invert * mypy fixup * trim runtime * use TYPE_CHECKING * xfail fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.