ENH: add cummax/cummin/cumprod support for arrow dtypes #54574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nice! i'd also be OK with implementing it for pyarrow>=13 and leaving it xfailed for earlier versions |
|
I would also be okay backporting this to 2.1 |
mroeschke
approved these changes
Aug 17, 2023
|
Thanks @lukemanley |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Aug 17, 2023
…for arrow dtypes
mroeschke
pushed a commit
that referenced
this pull request
Aug 17, 2023
…pport for arrow dtypes) (#54603) Backport PR #54574: ENH: add cummax/cummin/cumprod support for arrow dtypes Co-authored-by: Luke Manley <[email protected]>
mroeschke
pushed a commit
to mroeschke/pandas
that referenced
this pull request
Aug 18, 2023
…4574) * ENH: add cumax, cumin, cumprod support to ArrowExtensionArray * whatsnew * move whatsnew to 2.1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/v2.2.0.rstfile if fixing a bug or adding a new feature.un-xfails 186 tests which saves a chunk of time in
test_arrow.pyThe new pyarrow cumulative functions are only available starting in pyarrow version 13 which is not yet released but is currently tested in CI via the pyarrow nightly job. We could hold off on merging until pyarrow 13 is released if there are any concerns.