REF: Replace "pyarrow" string storage checks with variable #54535
+23
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Aug 15, 2023
| @@ -0,0 +1 @@ | |||
| arrow_string_storage = ("pyarrow",) | |||
There was a problem hiding this comment.
Could this be put in a conftest.py instead? IMO variables are kinda hard to discover here
There was a problem hiding this comment.
Do you want to use as a fixture or as a variable from conftest? Not sure how I feel about using this in every test function signature
There was a problem hiding this comment.
Was thinking as a fixture. Is it needed in all these string tests currently?
There was a problem hiding this comment.
in a bunch of them, inheritance makes it a bit ugly though
mroeschke
approved these changes
Aug 16, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Aug 17, 2023
…hecks with variable
mroeschke
pushed a commit
that referenced
this pull request
Aug 17, 2023
…rage checks with variable) (#54594) Backport PR #54535: REF: Replace "pyarrow" string storage checks with variable Co-authored-by: Patrick Hoefler <[email protected]>
mroeschke
pushed a commit
to mroeschke/pandas
that referenced
this pull request
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Precursor to the other pr