-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: Special-case setting nan into integer series #54527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MarcoGorelli
merged 13 commits into
pandas-dev:main
from
MarcoGorelli:special-case-int-nan-pdep6
Aug 28, 2023
Merged
Changes from 2 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
9be06be
wip
MarcoGorelli 3622ff4
Merge remote-tracking branch 'upstream/main' into special-case-int-na…
MarcoGorelli 1bfd932
add has_only_ints_or_nan cython helper
jorisvandenbossche 26bd53c
wip
MarcoGorelli d4e989a
take care of nat
MarcoGorelli 99767c0
fixup more tests
MarcoGorelli 5f99673
catch interval[int64, right] warning
MarcoGorelli 4f6869f
just use isna
MarcoGorelli 13c6870
Merge remote-tracking branch 'upstream/main' into special-case-int-na…
MarcoGorelli f88bcc1
fixup tests
MarcoGorelli 02cf661
noop
MarcoGorelli 19a7aa1
Merge remote-tracking branch 'upstream/main' into special-case-int-na…
MarcoGorelli a2b5144
exclude NaT
MarcoGorelli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So one thing that this doesn't yet do, is checking for the proper range for lower bitwidth integers.
For example setting [1000.0, np.nan] into a int8 Series should still raise the warning because 1000 is too big, but this helper function will now say it are only integers or NaN.