Skip to content

Speed up string inference in maybe_convert_objects #54498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 12, 2023
Merged

Speed up string inference in maybe_convert_objects #54498

merged 3 commits into from
Aug 12, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Aug 11, 2023

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@phofl phofl requested a review from jbrockmendel August 11, 2023 13:08
@phofl phofl requested a review from WillAyd as a code owner August 11, 2023 13:08
@phofl phofl added this to the 2.1 milestone Aug 11, 2023
@mroeschke mroeschke added the Strings String extension data type and string data label Aug 11, 2023
@jbrockmendel
Copy link
Member

ping on green

@phofl
Copy link
Member Author

phofl commented Aug 12, 2023

Green, merging

@phofl phofl merged commit 50910f9 into pandas-dev:main Aug 12, 2023
@phofl phofl deleted the perf_string_inference- branch August 12, 2023 12:06
@lithomas1
Copy link
Member

@meeseeksdev backport 2.1.x.

@meeseeksmachine meeseeksmachine mentioned this pull request Aug 12, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Aug 12, 2023
@phofl @meeseeksmachine
Backport PR pandas-dev#54498: Speed up string inference in maybe_conv…
f3391a4 
…ert_objects
phofl added a commit that referenced this pull request Aug 12, 2023
@meeseeksmachine @phofl
Backport PR #54498 on branch 2.1.x (Speed up string inference in mayb…
7f25175 
…e_convert_objects) (#54512)

Backport PR #54498: Speed up string inference in maybe_convert_objects

Co-authored-by: Patrick Hoefler <[email protected]>
mroeschke pushed a commit to mroeschke/pandas that referenced this pull request Aug 18, 2023
@phofl @mroeschke
Speed up string inference in maybe_convert_objects (pandas-dev#54498)
b2314c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel approved these changes

@WillAyd WillAyd Awaiting requested review from WillAyd

Assignees
No one assigned
Labels
Strings String extension data type and string data
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
4 participants
@phofl @jbrockmendel @lithomas1 @mroeschke