Fix inference for fixed with numpy strings with arrow string option #54496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jbrockmendel gentle ping |
lithomas1
reviewed
Aug 21, 2023
| pa = pytest.importorskip("pyarrow") | ||
| expected = Series(["a", "b"], dtype=pd.ArrowDtype(pa.string())) | ||
| with pd.option_context("future.infer_string", True): | ||
| ser = Series(np.array(["a", "b"])) |
There was a problem hiding this comment.
It might be good to specify dtype explictly here.
Not sure how numpy's string dtype work is coming along, but just in case that becomes the default, it would be good to future-proof this.
There was a problem hiding this comment.
I'd prefer to keep this, we should infer the default type as arrow backed strings for now, that's the mos common use case for users
lithomas1
reviewed
Aug 21, 2023
| {"a": ["a", "b"], "b": ["c", "d"]}, | ||
| dtype=dtype, | ||
| columns=Index(["a", "b"], dtype=dtype), | ||
| ) |
There was a problem hiding this comment.
Can you add a test for a 2-D string ndarray?
e.g.
a = np.array([['a', 'b'], ['c', 'd']])
df = pd.DataFrame(a)
|
Moving off milestone for now. If Brock reviews in time, can always put it back. |
|
@jbrockmendel ping |
jbrockmendel
approved these changes
Aug 21, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Aug 21, 2023
…ngs with arrow string option
mroeschke
pushed a commit
that referenced
this pull request
Aug 21, 2023
…y strings with arrow string option) (#54672) Backport PR #54496: Fix inference for fixed with numpy strings with arrow string option Co-authored-by: Patrick Hoefler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.