Skip to content

DOC: updated required dependencies list #54493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 15, 2023
Merged

DOC: updated required dependencies list #54493

merged 3 commits into from
Aug 15, 2023

Conversation

rsm-23
Copy link
Contributor

@rsm-23 rsm-23 commented Aug 11, 2023 •
edited
Loading

@rsm-23
Copy link
Contributor Author

rsm-23 commented Aug 11, 2023

@alimcmaster1 tagging as reviewer

@mroeschke mroeschke added the Docs label Aug 11, 2023
@mroeschke
Copy link
Member

@MarcoGorelli could you remind me why we added tzdata as a required dependency?

@asishm-wk
Copy link

@MarcoGorelli could you remind me why we added tzdata as a required dependency?

added here #51247

@alimcmaster1
Copy link
Member

@MarcoGorelli could you remind me why we added tzdata as a required dependency?

Think its a PEP 615 thing - zoneinfo only works on certain platforms.
https://peps.python.org/pep-0615/#abstract

@mroeschke
Copy link
Member

Right but I'm curious why we didn't make this dependency platform specific

@MarcoGorelli
Copy link
Member

On my phone, but IIRC that was a request from @lithomas1

@lithomas1
Copy link
Member

I don't think it's necessary on all platforms but doesn't hurt.

We are able to enforce that tzdata exists (the db isn't guaranteed to exist on all platforms) and also enforce a minimum version by putting it as a dep.

@mroeschke mroeschke added this to the 2.1 milestone Aug 15, 2023
@mroeschke mroeschke merged commit 4cb2418 into pandas-dev:main Aug 15, 2023
@mroeschke
Copy link
Member

Thanks @rsm-23

@meeseeksmachine meeseeksmachine mentioned this pull request Aug 15, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Aug 15, 2023
@rsm-23 @meeseeksmachine
Backport PR pandas-dev#54493: DOC: updated required dependencies list
d63b327
mroeschke pushed a commit that referenced this pull request Aug 15, 2023
@meeseeksmachine @rsm-23
Backport PR #54493 on branch 2.1.x (DOC: updated required dependencie…
4160d69 
…s list) (#54562)

Backport PR #54493: DOC: updated required dependencies list

Co-authored-by: Rajat Subhra Mukherjee <[email protected]>
mroeschke pushed a commit to mroeschke/pandas that referenced this pull request Aug 18, 2023
@rsm-23 @mroeschke
DOC: updated required dependencies list (pandas-dev#54493)
2bc1fb8 
updated required dependencies list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

DOC: tzdata should be listed as a required dependency since 2.0.0
6 participants
@rsm-23 @mroeschke @asishm-wk @alimcmaster1 @MarcoGorelli @lithomas1